fix(oidc): remove unnecessary e2e-encryption imports #4553
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilimnik
changed the title
|
I have no Idea why the test failed, it works locally on my machine :) |
|
It seems like the whole |
|
Yeah, OIDC requires the cross-process lock because it requires one, in case a refresh happened in another process (can happen on iOS because the process receiving notifications (NSE) runs concurrently to the app's process). The "plan" to fix this properly would be to have a single cross-process lock throughout the entire app, which has been somewhat sketched in this comment. In the meanwhile, I'm not sure there's much we can do; maybe document the requirement would be a nice win, to not confuse other future readers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the crate won't build without the
e2e-encryptionfeature enabled. This does not make it build rather it is a step towards it.There is still https://github.com/neodyme-labs/matrix-rust-sdk/blob/oidc_e2e/crates/matrix-sdk/src/oidc/mod.rs#L319 missing.
Signed-off-by: Daniel Kilimnik [email protected]